Mantis Bugtracker
Main | My View | View Issues | Change Log | Roadmap | Docs | My Account
  

Viewing Issue Simple Details [ Jump to Notes ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000103 [GGZ Gtk+ Client] default minor always 2009-04-28 22:17 2009-07-13 19:34
Reporter phomes View Status public  
Assigned To josef
Priority normal Resolution fixed  
Status resolved  
Summary 0000103: ggz-gtk uses deprecated gtk api
Description Deprecated gtk api will not be available in gtk3 and should be replaced.
Gtk should also be include with "#include <gtk/gtk.h>" only. No single includes.

I will provide a few patches but feel free to help out.

The worst offender is GTK_SIGNAL_FUNC. Except for that one I have added all the usage of deprecated gtk calls as Additional Informaion:
Additional Information ggz-gtk/client.c: GtkTooltips *client_window_tips;
ggz-gtk/client.c: gtk_tool_item_set_tooltip(GTK_TOOL_ITEM(widget), \
ggz-gtk/client.c: client_window_tips = gtk_tooltips_new();
ggz-gtk/types.c: menu = gtk_option_menu_get_menu(GTK_OPTION_MENU(tmp));
ggz-gtk/types.c: gtk_menu_append(GTK_MENU(menu), menuitem);
ggz-gtk/types.c: menu = gtk_option_menu_get_menu(GTK_OPTION_MENU(tmp));
ggz-gtk/types.c: gtk_menu_append(GTK_MENU(menu), menuitem);
ggz-gtk/types.c: filter_optionmenu = gtk_option_menu_new();
ggz-gtk/types.c: gtk_option_menu_set_menu(GTK_OPTION_MENU(filter_optionmenu),
ggz-gtk/xtext.c: gtk_object_sink ((GtkObject *) xtext->adj);
ggz-gtk/xtext.c: parent_class = gtk_type_class (gtk_widget_get_type ());
ggz-gtk/xtext.c:GtkType
ggz-gtk/xtext.c: static GtkType xtext_type = 0;
ggz-gtk/props.c: if (gtk_font_selection_dialog_get_font_name(GTK_FONT_SELECTION_DIALOG(props_font_dialog)) != NULL )
ggz-gtk/props.c: gtk_font_selection_dialog_get_font_name(GTK_FONT_SELECTION_DIALOG(props_font_dialog)));
ggz-gtk/props.c: if (gtk_font_selection_dialog_get_font_name(GTK_FONT_SELECTION_DIALOG(props_font_dialog)) != NULL )
ggz-gtk/props.c: gtk_font_selection_dialog_get_font_name(GTK_FONT_SELECTION_DIALOG(props_font_dialog)));
ggz-gtk/glade/main.glade: <class>GtkCList</class>
ggz-gtk/glade/main.glade: <class>GtkCList</class>
ggz-gtk/glade/main.glade: <class>GtkCList</class>
ggz-gtk/glade/props.glade: <class>GtkCList</class>
ggz-gtk/glade/props.glade: <class>GtkText</class>
ggz-gtk/glade/props.glade: <class>GtkCombo</class>
ggz-gtk/glade/props.glade: <child_name>GtkCombo:entry</child_name>
ggz-gtk/glade/license.glade: <class>GtkText</class>
ggz-gtk/glade/motd.glade: <class>GtkText</class>
ggz-gtk/glade/launch.glade: <class>GtkCombo</class>
ggz-gtk/glade/launch.glade: <child_name>GtkCombo:entry</child_name>
ggz-gtk/glade/login.glade: <class>GtkCombo</class>
ggz-gtk/glade/login.glade: <child_name>GtkCombo:entry</child_name>
ggz-gtk/glade/info.glade: <class>GtkPixmap</class>
ggz-gtk/glade/types.glade: <class>GtkCList</class>
ggz-gtk/glade/types.glade: <class>GtkOptionMenu</class>
ggz-gtk/xtext.h:GtkType INTERNAL gtk_xtext_get_type (void);
Tags No tags attached.
Attached Files ? file icon patch_gtj [^] (25,997 bytes) 2009-04-28 22:17
? file icon patch [^] (795 bytes) 2009-05-03 23:01

- Relationships

-  Notes
(0000180)
phomes (reporter)
2009-05-03 23:00

 A few more fixes in this patch. Also found that the stuff in client.c was ifdef'ed. The updated list:

ggz-gtk/types.c: menu = gtk_option_menu_get_menu(GTK_OPTION_MENU(tmp));
ggz-gtk/types.c: gtk_menu_append(GTK_MENU(menu), menuitem);
ggz-gtk/types.c: menu = gtk_option_menu_get_menu(GTK_OPTION_MENU(tmp));
ggz-gtk/types.c: gtk_menu_append(GTK_MENU(menu), menuitem);
ggz-gtk/types.c: filter_optionmenu = gtk_option_menu_new();
ggz-gtk/types.c: gtk_option_menu_set_menu(GTK_OPTION_MENU(filter_optionmenu),
ggz-gtk/xtext.c:GtkType
ggz-gtk/xtext.c: static GtkType xtext_type = 0;
ggz-gtk/props.c: if (gtk_font_selection_dialog_get_font_name(GTK_FONT_SELECTION_DIALOG(props_font_dialog)) != NULL )
ggz-gtk/props.c: gtk_font_selection_dialog_get_font_name(GTK_FONT_SELECTION_DIALOG(props_font_dialog)));
ggz-gtk/props.c: if (gtk_font_selection_dialog_get_font_name(GTK_FONT_SELECTION_DIALOG(props_font_dialog)) != NULL )
ggz-gtk/props.c: gtk_font_selection_dialog_get_font_name(GTK_FONT_SELECTION_DIALOG(props_font_dialog)));
ggz-gtk/glade/main.glade: <class>GtkCList</class>
ggz-gtk/glade/main.glade: <class>GtkCList</class>
ggz-gtk/glade/main.glade: <class>GtkCList</class>
ggz-gtk/glade/props.glade: <class>GtkCList</class>
ggz-gtk/glade/props.glade: <class>GtkText</class>
ggz-gtk/glade/props.glade: <class>GtkCombo</class>
ggz-gtk/glade/props.glade: <child_name>GtkCombo:entry</child_name>
ggz-gtk/glade/license.glade: <class>GtkText</class>
ggz-gtk/glade/motd.glade: <class>GtkText</class>
ggz-gtk/glade/launch.glade: <class>GtkCombo</class>
ggz-gtk/glade/launch.glade: <child_name>GtkCombo:entry</child_name>
ggz-gtk/glade/login.glade: <class>GtkCombo</class>
ggz-gtk/glade/login.glade: <child_name>GtkCombo:entry</child_name>
ggz-gtk/glade/info.glade: <class>GtkPixmap</class>
ggz-gtk/glade/types.glade: <class>GtkCList</class>
ggz-gtk/glade/types.glade: <class>GtkOptionMenu</class>
ggz-gtk/xtext.h:GtkType INTERNAL gtk_xtext_get_type (void);
(0000181)
josef (manager)
2009-05-04 05:32

 Are those changes compatible with Gtk 2.x and 3.x alike, or are they meant to go into a 3.x branch?
(0000182)
AndreKlapper (reporter)
2009-05-04 08:27

 These changes are compatible with Gtk 2.x. Everything that is covered by the patch(es) is already deprecated API in the current GTK 2.16 version.
(0000183)
phomes (reporter)
2009-05-14 16:51

 Andre's comment is correct. The patches are good to go in 2.x version. Replacements for the deprecated API is already in place.

Is there interest in getting these patches in?
(0000184)
josef (manager)
2009-05-14 17:28

 Definitely. I was holding back with comments because my involvement with the Gtk+ client has never been above zero dot five or so. If you don't mind, I'd give you an SVN account and you can take all the credits for any changes you deem important, but also all the slaps if anything goes royally wrong :-)
(0000206)
phomes (reporter)
2009-06-23 08:30

 I don't expect to do much more than the needed fixes to be GNOME 3 ready. Setting up an svn account just for this is probably overkill. You can blame me anyway since I provided the patches :)

Also do you have an eta for ggz 1.0? We will need for GNOME 3/2.30 but I would really prefer to get it in by 2.28 if possible?
(0000212)
AndreKlapper (reporter)
2009-07-13 18:35

 josef: Can you please commit this? I'd really prefer to see this getting some testing before GNOME 2.28 is going to be released in two months.

Thanks in advance!
(0000213)
josef (manager)
2009-07-13 19:34

 Patches are committed to SVN trunk in r10939.

- Issue History
Date Modified Username Field Change
2009-04-28 22:17 phomes New Issue
2009-04-28 22:17 phomes File Added: patch_gtj
2009-05-03 23:00 phomes Note Added: 0000180
2009-05-03 23:01 phomes File Added: patch
2009-05-03 23:01 phomes Issue Monitored: phomes
2009-05-04 05:32 josef Note Added: 0000181
2009-05-04 08:27 AndreKlapper Note Added: 0000182
2009-05-04 08:27 AndreKlapper Issue Monitored: AndreKlapper
2009-05-14 16:51 phomes Note Added: 0000183
2009-05-14 17:28 josef Note Added: 0000184
2009-06-23 08:30 phomes Note Added: 0000206
2009-07-13 18:35 AndreKlapper Note Added: 0000212
2009-07-13 19:34 josef Note Added: 0000213
2009-07-13 19:34 josef Status new => resolved
2009-07-13 19:34 josef Resolution open => fixed
2009-07-13 19:34 josef Assigned To => josef

Mantis 1.1.6[^]
Copyright © 2000 - 2008 Mantis Group
Powered by Mantis Bugtracker